feat: increase the timeout of lvstore creation #178

derekbit · 2024-12-10T05:32:36Z

Which issue(s) this PR fixes:

What this PR does / why we need it:

While creating a big lvstore, 60-second timeout is apparently not enough. To address the issue, we replace SendCommand which has only 60-second timeout with SendCommandWithLongTimeout.

Special notes for your reviewer:

Additional documentation or context

While creating a big lvstore, 60-second timeout is apparently not enough. To address the issue, we replace SendCommand which has only 60-second timeout with SendCommandWithLongTimeout. Longhorn 9221 Signed-off-by: Derek Su <[email protected]>

coderabbitai · 2024-12-10T05:32:44Z

Walkthrough

The changes in this pull request involve modifications to several methods in the Client struct located in pkg/spdk/client/basic.go. The primary alteration is the replacement of the SendCommand method with SendCommandWithLongTimeout across multiple methods to accommodate longer processing times for operations related to logical volumes and NVMe controllers. This adjustment aims to enhance the timeout handling for these operations while maintaining the overall structure and logic of the methods.

Changes

File Path	Change Summary
pkg/spdk/client/basic.go	Updated multiple methods to use `SendCommandWithLongTimeout` instead of `SendCommand`.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure Longhorn can provision volumes larger than 20TB (9221)	✅

Possibly related PRs

fix: decrease ctrlr_loss_timeout_sec for base bdev #170: This PR modifies timeout constants related to NVMe controller handling, which is relevant to the changes made in the main PR that also involve timeout adjustments for NVMe operations.
chore: add an example for the timeouts of spdk bdev_nvme_attach_controller #172: This PR provides an example related to timeout settings for the SPDK NVMe controller, which connects to the broader context of timeout handling addressed in the main PR.

Suggested reviewers

innobead
c3y1huang
shuo-wu
DamiaSan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-12-10T05:34:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.88%. Comparing base (e5a448a) to head (37f5f37).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   22.88%   22.88%           
=======================================
  Files          34       34           
  Lines        4842     4842           
=======================================
  Hits         1108     1108           
  Misses       3557     3557           
  Partials      177      177

Flag	Coverage Δ
unittests	`22.88% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e5a448a and 37f5f37.

📒 Files selected for processing (1)

pkg/spdk/client/basic.go (1 hunks)

pkg/spdk/client/basic.go

derekbit requested review from c3y1huang and DamiaSan December 10, 2024 05:32

derekbit self-assigned this Dec 10, 2024

derekbit requested a review from shuo-wu December 10, 2024 05:33

coderabbitai bot reviewed Dec 10, 2024

View reviewed changes

pkg/spdk/client/basic.go Show resolved Hide resolved

derekbit requested a review from innobead December 10, 2024 05:38

innobead approved these changes Dec 10, 2024

View reviewed changes

innobead merged commit 92898a8 into longhorn:main Dec 10, 2024
10 checks passed

derekbit mentioned this pull request Dec 10, 2024

[BUG] Longhorn is unable to provision volumes larger than 20TB longhorn/longhorn#9221

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: increase the timeout of lvstore creation #178

feat: increase the timeout of lvstore creation #178

derekbit commented Dec 10, 2024 •

edited

Loading

coderabbitai bot commented Dec 10, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 10, 2024 •

edited

Loading

coderabbitai bot left a comment

feat: increase the timeout of lvstore creation #178

feat: increase the timeout of lvstore creation #178

Conversation

derekbit commented Dec 10, 2024 • edited Loading

Which issue(s) this PR fixes:

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

coderabbitai bot commented Dec 10, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 10, 2024 • edited Loading

Codecov Report

coderabbitai bot left a comment

Choose a reason for hiding this comment

derekbit commented Dec 10, 2024 •

edited

Loading

coderabbitai bot commented Dec 10, 2024 •

edited

Loading

codecov bot commented Dec 10, 2024 •

edited

Loading